fix(csv): use configured field separator in parallel chunk path#2601
Open
atlan-owen wants to merge 1 commit into
Open
fix(csv): use configured field separator in parallel chunk path#2601atlan-owen wants to merge 1 commit into
atlan-owen wants to merge 1 commit into
Conversation
…484) CSVReader.streamRows() hardcoded comma in chunk write/read, crashing on non-comma-delimited files with CsvParseException. Promote fieldSeparator to a class field and use it at lines 190, 202, 219. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: atlan-owen <owen.price@atlan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSVReader.streamRows()hardcoded','in 3 places when splitting and re-reading chunk files for parallel batch processing, causingCsvParseExceptionon any non-comma-delimited CSV (e.g. semicolon, common in European Excel locales)fieldSeparatorwas a bare constructor parameter, not aval, so it was inaccessible in class methods — promoted toprivate valand replaced all 3 hardcoded commasCSVFieldSeparatorTestproving the crash: semicolon CSV + comma reader throwsCsvParseException: Unexpected character after closing quote: ';'Context
Test plan
CSVFieldSeparatorTest— 3 tests proving semicolon works with correct separator, crashes with hardcoded comma, and comma control passespackage-toolkit:runtime:testsuite — 65/65 passspotlessApplyclean