Skip to content

APP-7827: Added support for AttributeDef.Options.applicable_ai_asset_types#686

Merged
Aryamanz29 merged 1 commit into
mainfrom
APP-7827
Jul 28, 2025
Merged

APP-7827: Added support for AttributeDef.Options.applicable_ai_asset_types#686
Aryamanz29 merged 1 commit into
mainfrom
APP-7827

Conversation

@Aryamanz29
Copy link
Copy Markdown
Member

✨ Description

https://atlanhq.atlassian.net/browse/APP-7827


🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

Describe how the change was tested. Include:

  • Steps to reproduce
  • Any relevant screenshots, logs, or links to successful workflow runs
  • Details on environment/setup if applicable

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

@Aryamanz29 Aryamanz29 requested a review from Copilot July 28, 2025 14:25
@Aryamanz29 Aryamanz29 self-assigned this Jul 28, 2025
@Aryamanz29 Aryamanz29 added the feature New feature or request label Jul 28, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for AttributeDef.Options.applicable_ai_asset_types to restrict custom attributes to specific AI asset types (AIApplication and AIModel). This enhancement allows for more granular control over which AI assets can have particular custom attributes applied to them.

  • Added new AIAssetTypes type definition for AI asset type validation
  • Implemented property getter/setter for applicable_ai_asset_types with validation logic
  • Updated the AttributeDef.create() method to accept the new parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyatlan/model/constants.py Defines the new AIAssetTypes type for AI asset type literals
pyatlan/model/typedef.py Implements the core functionality with property, validation, and creation method updates
tests/unit/test_typedef_model.py Adds test coverage for the new applicable_ai_asset_types parameter

Comment thread pyatlan/model/typedef.py Outdated
Comment thread pyatlan/model/typedef.py
Comment thread pyatlan/model/typedef.py
Comment thread pyatlan/model/typedef.py
@Aryamanz29 Aryamanz29 merged commit b3a2b0b into main Jul 28, 2025
57 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-7827 branch July 28, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants