APP-7827: Added support for AttributeDef.Options.applicable_ai_asset_types#686
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for AttributeDef.Options.applicable_ai_asset_types to restrict custom attributes to specific AI asset types (AIApplication and AIModel). This enhancement allows for more granular control over which AI assets can have particular custom attributes applied to them.
- Added new
AIAssetTypestype definition for AI asset type validation - Implemented property getter/setter for
applicable_ai_asset_typeswith validation logic - Updated the
AttributeDef.create()method to accept the new parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyatlan/model/constants.py | Defines the new AIAssetTypes type for AI asset type literals |
| pyatlan/model/typedef.py | Implements the core functionality with property, validation, and creation method updates |
| tests/unit/test_typedef_model.py | Adds test coverage for the new applicable_ai_asset_types parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
https://atlanhq.atlassian.net/browse/APP-7827
🧩 Type of change
Select all that apply:
✅ How has this been tested? (e.g. screenshots, logs, workflow links)
Describe how the change was tested. Include:
📋 Checklist