APP-7889: Fixed handling of source_tag when no attributes present#688
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the source_tag handling where the code would fail when a tag had no attributes present. The fix adds proper null/existence checks before accessing nested attribute dictionaries.
- Updated the translator to safely check for attributes existence before accessing nested keys
- Enhanced test coverage to include scenarios for source tags with attributes, without attributes, and deleted source tags
- Modified test assertions to account for the additional test cases and different behavior patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyatlan/model/translators.py | Added null safety checks when accessing tag attributes to prevent crashes |
| tests/unit/test_atlan_tag_name.py | Enhanced test coverage with multiple source tag scenarios and updated assertions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
https://atlanhq.atlassian.net/browse/APP-7889
🧩 Type of change
Select all that apply:
✅ How has this been tested? (e.g. screenshots, logs, workflow links)
Describe how the change was tested. Include:
📋 Checklist