feat(enums): add deprecated Phosphor icon names to AtlanIcon [BLDX-1096]#909
Merged
Conversation
Add 11 deprecated Phosphor icon values that customers may have persisted in tag/CM definitions. Without these, SDK deserialization fails when encountering old icon names like PhCircleWavyWarning, breaking tag resolution for the entire export. Each deprecated entry has a comment pointing to its replacement. Includes 46 unit tests covering existence, deserialization, and replacement mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 11 deprecated Phosphor icon values to AtlanIcon enum for backward compatibility. Customers with tag/CM definitions using old icon names (e.g. PhCircleWavyWarning) cause SDK deserialization failure — one unrecognized icon breaks all tag resolution for the entire export.
Changes
Added 11 deprecated entries to pyatlan/model/enums.py AtlanIcon enum, each with # Deprecated: use comment. 46 new unit tests.
Linear
https://linear.app/atlan-epd/issue/BLDX-1096