feat(models): sync pyatlan_v9 models from models@BLDX-1206 + fix 4 collection errors [BLDX-1206]#920
Merged
Merged
Conversation
…LDX-1206] Generated pyatlan_v9 Python models from the BLDX-1206 models branch, which includes UnstructuredV2 asset types (folder, container, object) sourced from the bigid branch (PART-718). New files: - unstructured_v2.py, unstructured_v2_container.py, unstructured_v2_folder.py - unstructured_v2_object.py, unstructured_v2_related.py, _init_unstructured_v2.py Also includes model updates for new typedef additions on master since BLDX-930 base (agentic, artifact, context, gcp_dataplex, skill, skill_artifact). Note: Knowledge.pkl skipped due to pre-existing getTypeNameFromMapping bug on master. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…[BLDX-1206] Regenerated all pyatlan_v9 models from atlanhq/models@BLDX-1206 (UnstructuredV2 typedefs from bigid branch) using corrected pkl flags (sdkOnly=true). Bug fixes that survive regeneration: - entity.py: add semantic field (SaveSemantic) — enables ref_by_guid/ref_by_qualified_name - referenceable.py: activate Referenceable.STATUS = InternalKeywordField(...) - data_contract.py: inline creator logic (remove DataContract.Attributes.creator() call) - tests: update DataContractAttributes usage (no nested Attributes class in v9) New UnstructuredV2 assets: unstructured_v2.py, unstructured_v2_container.py, unstructured_v2_folder.py, unstructured_v2_object.py, unstructured_v2_related.py Knowledge.pkl skipped (pre-existing getTypeNameFromMapping bug on master). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
**Referenceable deferred fields** (GUID, TYPE_NAME, CREATE_TIME, etc.) - Added missing InternalKeywordField/TextField/InternalNumericField assignments so Asset.GUID.order(), Asset.TYPE_NAME.eq() etc. work for search **Glossary meanings duplicate kwarg** - Filtered meanings from merged_rels in _atlas_glossary_from_nested to avoid double-passing since it's already an explicit kwarg **QuickSight field renames** - quick_sight_import_mode → quick_sight_dataset_import_mode - quick_sight_type → quick_sight_dataset_field_type / quick_sight_folder_type - quick_sight_column_count → quick_sight_dataset_column_count **Schema field alias** - Added schema_external_location property → sql_external_location **Anchor in attributes for AtlasGlossaryTerm** - Moved anchor to AtlasGlossaryTermAttributes (not RelationshipAttributes) - Removed anchor from _ATLAS_GLOSSARY_TERM_REL_FIELDS **AtlasClassification fields for tag translation** - Added type_name: Union[Any] to accept AtlanTagName objects post-translation - Added source_tag_attachments, tag_id, restrict_propagation_through_* fields - Fixed ReferenceableNested.classifications to decode as List[AtlasClassification] **Entity.depth field** - Added depth: Union[int, UnsetType] for lineage list responses - Also added to PythonMsgspecRenderer.pkl (survives regeneration) **Translators sourceTagAttachments** - Always emit sourceTagAttachments: [] when attr_id found (even if no attachments) so the field is consistently present for recognized source tags Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
All fixes are now in the Pkl renderer or overlays — they survive regeneration. **Renderer changes (PythonMsgspecRenderer.pkl):** - AtlasClassification: type_name→Any, add source_tag_attachments/tag_id/restrict_propagation_* fields - Entity: add depth (lineage), semantic (SaveSemantic) fields - Referenceable deferred section: activate STATUS, GUID, TYPE_NAME, CREATED_BY, UPDATED_BY, ATLAN_TAGS, PROPAGATED_ATLAN_TAGS, ASSIGNED_TERMS, SUPER_TYPE_NAMES, CREATE_TIME, UPDATE_TIME, CUSTOM_ATTRIBUTES from InternalKeywordField/InternalKeywordTextField/InternalNumericField - ReferenceableNested.classifications: Union[List[AtlasClassification]] (enables proper decode) - renderFromNestedFunction: skip nestedTopLevelFields already in relAttrs (prevents 'meanings' dupe) - renderAssetType: implement regularizeRelationships (anchor goes to attributes not rel_attrs) **Overlay changes:** - schema.py: add schema_external_location property → sql_external_location - quick_sight_folder.py: correct field name quick_sight_type - atlas_glossary_category.py / atlas_glossary.py: handled by renderer fix for meanings **Non-generated file fixes:** - translators.py / aio/translators.py: _CLASSIFICATION_NAMES produce str not AtlanTagName (purposeClassifications stays as str; purpose_atlan_tags property wraps them when accessed) - translators.py / aio/translators.py: always emit sourceTagAttachments=[] for recognized source tags **Test updates:** - quick_sight_folder_test.py: quick_sight_folder_type → quick_sight_type (generated name) - quick_sight_dataset_test.py: quick_sight_dataset_import_mode → quick_sight_import_mode - quick_sight_dataset_field_test.py: quick_sight_dataset_field_type → quick_sight_type Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Member
Author
✅ All tests passing after final regeneration3761 passed, 0 failed — verified by running All 63 pre-existing failures are now fixed and survive regeneration (fixes live in the Pkl renderer or overlays, not the generated files). Key renderer fixes that make everything work correctly post-regen:
See |
Review CompleteVerdict: ✅ Approve This PR successfully syncs regenerated pyatlan_v9 models and fixes 4 test collection errors. See inline comments for detailed feedback. Security Review Passed - No API keys/tokens in logs, no verify=False, no base_url issues. CI Status - All v9 QA checks and unit tests passing (3.9-3.13), vulnerability scans passing. One minor note: Duplicate field descriptors in referenceable.py (harmless, see inline comment). Good work on the model sync! |
Aryamanz29
added
run_pyatlan_v9_integration_test
…ks clean [BLDX-1206] After restoring validate/minimize/relate methods in renderer and fixing the ModelRenderer.getTypeNameFromMapping bug: - Knowledge.pkl now generates correctly (knowledge_file.py exists) - useLocalTypeAsPrefix=true now works → QuickSight/Schema field names use proper prefixes (quick_sight_folder_type, quick_sight_dataset_import_mode, schema_external_location) - All asset classes get validate(), minimize(), relate() methods generated - Tests reverted to use original (correct) field names that the typedefs always intended QuickSight/Schema overlay parameter names updated to match generated field names. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Aryamanz29
force-pushed
the
sync-models-BLDX-1206
branch
from
fe9e9a1 to
66f1a40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atlanhq/models@BLDX-1206New UnstructuredV2 models
unstructured_v2.py,unstructured_v2_container.py,unstructured_v2_folder.pyunstructured_v2_object.py,unstructured_v2_related.py,_init_unstructured_v2.pyBug fixes (survive regeneration)
semanticfield on Entityentity.py(+ renderer fix in models)ref_by_guid/ref_by_qualified_namepassedsemantic=but Entity Struct had no such fieldReferenceable.STATUSreferenceable.pydeferred section# DEFERREDbut never activated;Asset.STATUS.in_lineagereturned NoneDataContract.creatordata_contract.py+ overlayDataContract.Attributes.creator()— inlined logic directlyDataContractAttributestype hinttests_v9/unit/model/data_contract_test.pyDataContract.Attributes; updated to top-level classTest Results
mainbefore this PR)Test Plan
python -m pytest tests_v9/unit --tb=no -q— expect 3728 passed, 63 pre-existing failuresmainbaseline🤖 Generated with Claude Code