Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/jperf 566 fix ci flakiness #3

Merged
merged 10 commits into from
Sep 5, 2019

Conversation

dagguh
Copy link
Contributor

@dagguh dagguh commented Aug 30, 2019

No description provided.

@dagguh dagguh requested a review from wyrzyk August 30, 2019 14:41
wyrzyk
wyrzyk previously approved these changes Aug 30, 2019
@dagguh dagguh force-pushed the issue/JPERF-566-fix-ci-flakiness branch from 5333f7b to 9cce5a8 Compare August 30, 2019 15:15
@dagguh
Copy link
Contributor Author

dagguh commented Aug 30, 2019

Here's 4 runs of da9abac :

It still flakes. I could bump the timeout even further, but there is something fishy here. Looking in the stdout of the tests from the test reports in the artifacts we can look for the org.apache.catalina.startup.Catalina.start Server startup in line. We see two such lines, due to two test methods. One reports in 11-13 seconds and the other (docker-to-docker) is 170-280 seconds. And then yet again, one times out completely despite an 8 minute timeout.

I'll try to replace the log polling with GUI polling

@dagguh dagguh force-pushed the issue/JPERF-566-fix-ci-flakiness branch from 8970dfb to e07f524 Compare August 30, 2019 16:07
@dagguh
Copy link
Contributor Author

dagguh commented Aug 30, 2019

https://circleci.com/workflow-run/fa542720-2a09-40a1-ba5e-fc00fc432c4f
This flake is the second kind: it's unhappy with the admin fullname field.
This blocks me from merging atlassian/jira-actions#29 and I have no idea how to fix it.

wyrzyk
wyrzyk previously approved these changes Sep 4, 2019
@dagguh
Copy link
Contributor Author

dagguh commented Sep 4, 2019

This is still not working, I'll close and reopen when CircleCI goes green

@dagguh dagguh closed this Sep 4, 2019
@dagguh
Copy link
Contributor Author

dagguh commented Sep 4, 2019

The video from the CI showed that the license setup takes around 60 seconds and our timeout for the next screen is also 60 seconds. I bumped the WD timeout and now it's all green. Even after a full 4x rerun or two.
The extra timeout means the CI runs for a little longer.
So this trades a minute (or two) of dev loop for reliability. In total, this should save a lot of time, due to no need for reruns.

it.navigate().to(uri.toURL())
it.findElements(By.id("jira")).firstOrNull()
} catch (e: Exception) {
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the ExpectedCondition SPI

@dagguh dagguh merged commit 7410e4d into atlassian:master Sep 5, 2019
@dagguh dagguh deleted the issue/JPERF-566-fix-ci-flakiness branch September 5, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants