Standardize stm32 gpio driver error returns#1448
Closed
UncleGrumpy wants to merge 2 commits intoatomvm:mainfrom
Closed
Standardize stm32 gpio driver error returns#1448UncleGrumpy wants to merge 2 commits intoatomvm:mainfrom
UncleGrumpy wants to merge 2 commits intoatomvm:mainfrom
Conversation
Standardizes stm32 gpio driver error returns. Nif functions raise `Error`, port functions return
`{error, Reason}` on errors.
Addresses some concerns raised in issue atomvm#1442.
With atomvm#1408 this closes issue atomvm#894
Signed-off-by: Winford <winford@object.stream>
Introduces platform_defaultatoms.{c,h,def} for the stm32 platform and handles the creation of atoms
in a safer way.
See issue atomvm#1442
Signed-off-by: Winford <winford@object.stream>
Collaborator
Author
|
Closed because we migrated stm32 to a new codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes stm32 gpio driver error returns. Nif functions raise
Error, port functions return{error, Reason}on errors.Handle atom creation more safely, see issue #1442
With #1408 this closes issue #894
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later