Skip to content

Run codeql anaysis on all platforms #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

UncleGrumpy
Copy link
Collaborator

Add codeql to esp32-build.yaml workflow
Add codeql to pico-build.yaml workflow
Add codeql to stm32-build.yaml workflow
Add codeql to wasm-build.yaml workflow

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@UncleGrumpy UncleGrumpy marked this pull request as draft February 10, 2025 00:32
@UncleGrumpy UncleGrumpy force-pushed the codeql_everywhere branch 6 times, most recently from 00a571b to dd0aff2 Compare February 10, 2025 02:36
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@UncleGrumpy UncleGrumpy force-pushed the codeql_everywhere branch 22 times, most recently from 205cdad to 742d665 Compare February 10, 2025 07:41
@UncleGrumpy UncleGrumpy force-pushed the codeql_everywhere branch 2 times, most recently from 54e30a9 to 135b560 Compare February 17, 2025 06:51
@UncleGrumpy UncleGrumpy marked this pull request as ready for review February 17, 2025 07:19
@UncleGrumpy
Copy link
Collaborator Author

This does reveal some new issues for esp32, rp2, and wasm ports.

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree I wouldn't change release-0.6, except for the obvious fixes and CI updates to keep it working. What do you think? If you agree I would target main and merge it.

@UncleGrumpy
Copy link
Collaborator Author

I don't have a strong opinion, my reasoning behind targeting 0.6 was to help catch any regressions that future bug fixes may introduce, and to expose the few bugs in the pico and enscripten platforms that this will reveal after merging - but those are likely the same in main.

I will rebase this on main later today.

Add codeql to esp32-build.yaml workflow
Add codeql to pico-build.yaml workflow
Add codeql to stm32-build.yaml workflow
Add codeql to wasm-build.yaml workflow

Signed-off-by: Winford <[email protected]>
@bettio bettio changed the base branch from release-0.6 to main May 3, 2025 13:44
@UncleGrumpy
Copy link
Collaborator Author

Now rebased on main.

@UncleGrumpy UncleGrumpy mentioned this pull request May 3, 2025
@UncleGrumpy UncleGrumpy requested a review from bettio May 3, 2025 17:55
@bettio bettio merged commit 02bb6dc into atomvm:main May 3, 2025
107 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants