Implement binary:match/2 and binary:match/3 #1621
Conversation
jgonet
force-pushed
the
jgonet/binary-match
branch
from
83bfbf1 to
79dfc02
Compare
|
I'll squash commits after review. |
| " true -> io:format(\"Expected ~B, got ~p\n\", [%i, R]) " | ||
| "end, " | ||
| "erlang:process_flag(trap_exit, false), \n" /* init(3) traps exits */ | ||
| "S = try %s:start() of\n" |
There was a problem hiding this comment.
What's the purpose of this change?
@pguyot did the last refactoring here, his opinion might be valuable here.
There was a problem hiding this comment.
With hard pattern matching in test, we won't catch badmatch without this try and while the command will still fail, we won't get nice error message.
There was a problem hiding this comment.
understood, sounds like a good idea. Since this change is unrelated to the Implement binary:match/2 and binary:match/3 it would be perfect to have it as a separated commit with this short explanation (we don't need an additional PR, just one more commit).
git log history should allow us to understand the rationale about why we did a change.
jgonet
force-pushed
the
jgonet/binary-match
branch
from
88b8b8d to
70ee6b9
Compare
| " true -> io:format(\"Expected ~B, got ~p\n\", [%i, R]) " | ||
| "end, " | ||
| "erlang:process_flag(trap_exit, false), \n" /* init(3) traps exits */ | ||
| "S = try %s:start() of\n" |
There was a problem hiding this comment.
understood, sounds like a good idea. Since this change is unrelated to the Implement binary:match/2 and binary:match/3 it would be perfect to have it as a separated commit with this short explanation (we don't need an additional PR, just one more commit).
git log history should allow us to understand the rationale about why we did a change.
Signed-off-by: Jakub Gonet <[email protected]>
Running tests with beam didn't catch exceptions which resulted in command failing with non-informational error. Now, we catch all exceptions, print them, and exit with error code. Signed-off-by: Jakub Gonet <[email protected]>
jgonet
force-pushed
the
jgonet/binary-match
branch
from
5ef2f33 to
846fa18
Compare
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later