Replace .S test for bs_test_unit with .erl test#2210
Open
pguyot wants to merge 2 commits intoatomvm:mainfrom
Open
Replace .S test for bs_test_unit with .erl test#2210pguyot wants to merge 2 commits intoatomvm:mainfrom
pguyot wants to merge 2 commits intoatomvm:mainfrom
Conversation
bettio
approved these changes
Mar 17, 2026
bettio
requested changes
Mar 17, 2026
Collaborator
bettio
left a comment
There was a problem hiding this comment.
Fails on OTP-29 rc1:
test_op_bs_test_unit:
CRASH
======
pid: <0.1.0>
Stacktrace:
[{test_op_bs_test_unit,test_unit_16,0,[{file,"/home/runner/work/AtomVM/AtomVM/tests/erlang_tests/test_op_bs_test_unit.erl"},{line,53}]},{test_op_bs_test_unit,start,0,[{file,"/home/runner/work/AtomVM/AtomVM/tests/erlang_tests/test_op_bs_test_unit.erl"},{line,36}]}]
cp: #CP<module: 0, label: 9, offset: 529>
x[0]: error
x[1]: {badmatch,<<2>>}
x[2]: {2,2,75,1,[{0,310},{0,2111}],error}
Stack
-----
#CP<module: 0, label: 2, offset: 120>
#CP<module: 0, label: 0, offset: 125>
Mailbox
-------
Monitors
--------
**End Of Crash Report**
Expected 0 but result is not an integer
test_op_bs_test_unit:FAILED
Collaborator
Author
|
OTP29 emits this opcode but eventually this test uncovered a bug in bs_match ensure_at_least which this PR now fixes in the first commit. |
7e32f73 to
2a36dd7
Compare
The unit alignment check in ensure_at_least must apply to (remaining - stride) not remaining, since stride bits will be consumed before the byte-aligned tail. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
2a36dd7 to
1a3a797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later