Fix a bug in CodeQL query where branches were summed and not maxed#2212
Open
pguyot wants to merge 1 commit intoatomvm:mainfrom
Open
Fix a bug in CodeQL query where branches were summed and not maxed#2212pguyot wants to merge 1 commit intoatomvm:mainfrom
pguyot wants to merge 1 commit intoatomvm:mainfrom
Conversation
When we can prove two branches are mutually exclusive, we should take the maximum of the allocation, not the sum. This yielded false positives. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
bettio
requested changes
Mar 18, 2026
Collaborator
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
CI gets stuck for a long time. I think there is some sort of infinite loop or anything like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we can prove two branches are mutually exclusive, we should take the maximum of the allocation, not the sum. This yielded false positives.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later