Skip to content

fix: detect parenthesis independently from punctuation ending links - #344

Open
hylobates-agilis wants to merge 1 commit into
atrium-rs:mainfrom
hylobates-agilis:main
Open

fix: detect parenthesis independently from punctuation ending links#344
hylobates-agilis wants to merge 1 commit into
atrium-rs:mainfrom
hylobates-agilis:main

Conversation

@hylobates-agilis

@hylobates-agilis hylobates-agilis commented Jul 31, 2026

Copy link
Copy Markdown

Hi,

Been facing an issue with the following text extract:

La première génération de jeux Pokémon a été portée sur PC (https://github.com/bryanthaboi/gen1recomp), avec un mod 3D voxels (https://github.com/DramaticShape/DramaticShapeVoxelMod) au chouette rendu : https://www.youtube.com/watch?v=AFHtLDx0QxM et https://www.youtube.com/watch?v=BxPkVhF1iMo

#PC #Pokémon #voxel

The first link included the parenthesis because there is a ) followed by a ,:

 facets: Some(
        [
[…]
                                    data: LinkData {
                                        uri: "https://github.com/bryanthaboi/gen1recomp)",
[…]
                                    data: LinkData {
                                        uri: "https://github.com/DramaticShape/DramaticShapeVoxelMod",
[…]

Hence this patch to separate the parenthesis stripping from the other punctuation stripping. Note that this does not fix crazy edge cases like https://foo.com/)?,!, that would necessitate to modify the global regex for re_ending_punctuation. I don’t know if it’s a great idea however…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant