Skip to content

DAC Support (Sync + Async) for both D5x and D11/D21 - #904

Open
rnd-ash wants to merge 17 commits into
atsamd-rs:masterfrom
rnd-ash:ft-dac
Open

DAC Support (Sync + Async) for both D5x and D11/D21#904
rnd-ash wants to merge 17 commits into
atsamd-rs:masterfrom
rnd-ash:ft-dac

Conversation

@rnd-ash

@rnd-ash rnd-ash commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Summary

Adds DAC support for D5x and D11

Both implementations contain oneshot write functions (Just write a voltage and keep the DAC output going), and a DMA functions (Both blocking and async) for writing buffers to the DAC.

It is also possible to monitor the DAC output voltage via the ADC now with Adc::read_dac0_output (Both sync and async functions provided)

Closes #696 and #39

@kyp44

kyp44 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@rnd-ash I see that you've now taken full ownership of the Pclk, which is great. Can you change the name of the release method to free? I think this name should be consistent across the HAL and numerous other peripherals already use free (e.g. Adc, Delay, Qspi), so I think it makes sense to stick with that.

@rnd-ash

rnd-ash commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

@kyp44 method name should be consistent now

@sajattack sajattack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, what's missing for d21 support?

@rnd-ash

rnd-ash commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

I thought I supported it with this as well?...

@sajattack

Copy link
Copy Markdown
Member

I thought I supported it with this as well?...

You did, I forgot the d11 file applied to both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants