Open
Conversation
Owner
|
Thanks! I’ll be upgrading my work project to mill 1.0 soon, and I’ll need this then. I plan to test it and publish it to Maven. |
Author
|
Any updates on this? 🙂 |
Owner
|
I haven’t been able to start yet because I’m still working on higher-priority tasks, but I do plan to address it, so please wait a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I thought I'd help out a bit with porting this plugin to Mill 1.0. I don't have a deep understanding of either Mill or Jib, but fortunately most of the changes are fairly mechanical. There's two bits that I'm not sure about, namely
jibToolsClasspathandresolvedRunIvyDeps.I also had to add a new version of the mill bootstrap script because the existing one doesn't work for newer mill versions. This accounts for most of the diff.