DXCDT-240: Prevent empty logo_url update payload inclusion
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
commented
Oct 13, 2022
| expect(wasUpdateCalled).to.equal(true); | ||
| }); | ||
|
|
||
| it('should not send updateSettings request if empty object passed', async () => { |
There was a problem hiding this comment.
This test is unrelated, but still a valid case nonetheless.
sergiught
approved these changes
Oct 14, 2022
Codecov ReportBase: 83.36% // Head: 83.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 83.36% 83.40% +0.03%
==========================================
Files 114 114
Lines 3331 3333 +2
Branches 614 615 +1
==========================================
+ Hits 2777 2780 +3
Misses 323 323
+ Partials 231 230 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Under certain and unknown, conditions, an empty string
logo_urlis returned when fetching branding settings. While I have not been able to reproduce the export of a blanklogo_url, is has been reported by #226 and #656, suggesting that real folks actually experience this. The proposed validation is simple enough and doesn't produce significant tech debt.🔗 References
Original issues: #226, #656
🎯 Testing
Added a test case for
logo_urlbeing omitted from update payload.Additionally, added an unrelated but important test around the prevention of sending an API request if branding settings is an empty object.