Skip to content

Quickstart-changes#10485

Closed
BcnCarlos wants to merge 2 commits intomasterfrom
quickstart-changes
Closed

Quickstart-changes#10485
BcnCarlos wants to merge 2 commits intomasterfrom
quickstart-changes

Conversation

@BcnCarlos
Copy link
Copy Markdown
Contributor

No description provided.

<% var i=0; _.forEach(connections, function(article) { %>
<% if (article.connection) { %>
<% if (article.public !== false) { %>
<a class="connection connection-public" href="<%- article.url %>">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified an issue in your code:

Detected a template variable used in an anchor tag with the 'href' attribute. This allows a malicious actor to input the 'javascript:' URI and is subject to cross- site scripting (XSS) attacks. If using a relative URL, start with a literal forward slash and concatenate the URL, like this: href='/<%= link %>'. You may also consider setting the Content Security Policy (CSP) header.

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by var-in-href.

You can view more details about this finding in the Semgrep AppSec Platform.

<% var i=0; _.forEach(connections, function(article) { %>
<% if (article.connection) { %>
<% if (article.public !== false) { %>
<a class="connection connection-public" href="<%- article.url %>">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified an issue in your code:

Detected a template variable used in an anchor tag with the 'href' attribute. This allows a malicious actor to input the 'javascript:' URI and is subject to cross- site scripting (XSS) attacks. If using a relative URL, start with a literal forward slash and concatenate the URL, like this: href='/<%= link %>'. You may also consider setting the Content Security Policy (CSP) header.

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by var-in-href.

You can view more details about this finding in the Semgrep AppSec Platform.

@BcnCarlos
Copy link
Copy Markdown
Contributor Author

This is in reference to #10484

That could not be merged due to unverified commits..

@BcnCarlos BcnCarlos closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants