-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenant OIDC logout configuration #517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 57 57
Lines 11269 11286 +17
=======================================
+ Hits 10775 10792 +17
Misses 373 373
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @ErwinSteffens, I hope you're doing well! I've updated the test records. Could you please sign your commits so we can proceed with merging the PR? Thanks for your contribution! |
3f80559
to
2534609
Compare
Done! |
2534609
to
60f5205
Compare
Hi @ErwinSteffens, I hope you're doing well! I noticed that the commits are not signed. Could you double-check on your end? |
60f5205
to
aba6c69
Compare
Ah, just signed my commit. Did it again now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@developerkunal You know when next release will be done? |
Hi @ErwinSteffens, Apologies for the late response, and thank you for your contribution! We released the latest version yesterday, which includes this feature. We look forward to more contributions from you in the future! |
🔧 Changes
Add OIDC logout tenant settings.
📚 References
🔬 Testing
I think it is pretty trivial change. You can test setting and reading the property and see if it reflects in the UI.
I had some issues with running E2E tests locally and updating the recordings.
📝 Checklist