Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Federated Connection Access Token (#1911)" #1918

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

nandan-bhat
Copy link
Contributor

📋 Changes

Removing federated connections implementation as this is not required at this moment.

@nandan-bhat nandan-bhat requested a review from a team as a code owner February 14, 2025 08:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 50 lines in your changes missing coverage. Please review.

Project coverage is 74.69%. Comparing base (caa7f45) to head (748c965).

Files with missing lines Patch % Lines
src/server/client.ts 0.00% 47 Missing ⚠️
src/server/session/stateless-session-store.ts 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
+ Coverage   72.64%   74.69%   +2.04%     
==========================================
  Files          19       19              
  Lines        1601     1379     -222     
  Branches      232      210      -22     
==========================================
- Hits         1163     1030     -133     
+ Misses        431      342      -89     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arpit-jn arpit-jn self-requested a review February 14, 2025 08:47
Copy link
Contributor

@arpit-jn arpit-jn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandan-bhat nandan-bhat merged commit 9cccf91 into main Feb 17, 2025
12 checks passed
@nandan-bhat nandan-bhat deleted the main-copy branch February 17, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants