fix: consistently treat returnTo parameter as an absolute path#2185
Merged
Conversation
Merged
d8b20ad to
14ff06b
Compare
frederikprijck
approved these changes
Jun 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
+ Coverage 82.88% 82.91% +0.02%
==========================================
Files 21 21
Lines 2092 2095 +3
Branches 372 372
==========================================
+ Hits 1734 1737 +3
Misses 351 351
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently the
returnToparameter is inconsistently treated: sometimes it's a URL (e.g.:https://example.com/dashboard) and other times as a path (/dashboard). This results in subtle bugs when building on the assumption that it is always an absolute path.This PR ensure that all instances of the
returnToparameter are treated as absolute paths.This was discovered as a bug with the
basePathhandling where thereturnToparameter was assumed to be an absolute path (e.g.:/base-path/dashboard). In reality, the host was prepended when constructing thereturnToparameter resulting in:http://localhost:3000/base-path/dashboard. With thebasePathenabled, this generated malformed URLs such as/base-path/http://localhost:3000/base-path/dashboard. This can only be reproduced when a base path is set.🎯 Testing
returnTopath in your login URL