merge sessionChanges before finalizing session after refresh #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
- Coverage 87.90% 87.88% -0.03%
==========================================
Files 37 37
Lines 4127 4120 -7
Branches 818 819 +1
==========================================
- Hits 3628 3621 -7
Misses 496 496
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tusharpandey13
approved these changes
Nov 17, 2025
tusharpandey13
added a commit
to tusharpandey13/nextjs-auth0
that referenced
this pull request
Nov 17, 2025
…th0#2401) - Pass sessionChanges to finalizeSession so beforeSessionSaved hook receives refreshed tokens - Add tests to verify beforeSessionSaved hook receives refreshed accessToken - Add tests to verify changes made in beforeSessionSaved hook are honored Co-authored-by: Wolfgang Goedel <[email protected]>
This was referenced Nov 17, 2025
tusharpandey13
added a commit
that referenced
this pull request
Nov 17, 2025
) - Pass sessionChanges to finalizeSession so beforeSessionSaved hook receives refreshed tokens - Add tests to verify beforeSessionSaved hook receives refreshed accessToken - Add tests to verify changes made in beforeSessionSaved hook are honored Co-authored-by: Wolfgang Goedel <[email protected]>
Contributor
|
This change is superseded by #2414. This was done to ensure that commits are signed. Orignal contribution history has been preserved. Hence closing this PR now. |
tusharpandey13
added a commit
that referenced
this pull request
Nov 17, 2025
) - Pass sessionChanges to finalizeSession so beforeSessionSaved hook receives refreshed tokens - Add tests to verify beforeSessionSaved hook receives refreshed accessToken - Add tests to verify changes made in beforeSessionSaved hook are honored Co-authored-by: Wolfgang Goedel <[email protected]>
tusharpandey13
added a commit
that referenced
this pull request
Nov 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
The
beforeSessionSavedhook should be called with the updated session after the tokenSet has been refreshed. A recent change in this PR fixed the behavior when requesting the access token via the token route. Thanks again for having responded to my issue so promptly.One case remains though where the old, buggy behavior remains: when
getAccessTokenis been called server side like it would be in next middleware. This PR fixes the issue in the same way the issue has been fixed elsewhere.📎 References
related PR: fix: make sure beforeSessionSaved hook gets the updated token after refresh
initial issue: beforeSessionSaved behaves differently when called after login or after token refresh
🎯 Testing
Unit tests included with the PR