fix(streamtimeout): exempt bulk export/import methods#3143
Open
ivanauth wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
area/api v1
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
be4ad12 to
c4cb74c
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
2 times, most recently
from
cd88072 to
0a289b6
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
0a289b6 to
31c2837
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
31c2837 to
8f82315
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
8f82315 to
31c2837
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming-timeout interceptor cancels a stream if the server is silent for
StreamingAPITimeout(default 30s), assuming a hung client. Bulk export/import legitimately go silent for long stretches between batches on large datasets, so the interceptor was cancelling healthy streams (clients sawRST_STREAM NO_ERROR).Add
WithExemptMethodsto the interceptor and exempt:PermissionsService/ExportBulkRelationshipsPermissionsService/ImportBulkRelationshipsExperimentalService/BulkExportRelationshipsExperimentalService/BulkImportRelationshipsAll other streaming methods keep the timeout.