Composite Sampler #250
Open
Composite Sampler #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrate composite sampler to confopt
Neonkraft
reviewed
May 5, 2025
| self.arch_parameters = arch_parameters | ||
|
|
||
| # get sample frequency from the samplers | ||
| self.sample_frequency = arch_samplers[0].sample_frequency |
There was a problem hiding this comment.
Do we still use sampling frequency in the code?
Neonkraft
reviewed
May 5, 2025
| for sampler in arch_samplers: | ||
| assert ( | ||
| self.sample_frequency == sampler.sample_frequency | ||
| ), "All the sampler must have the same sample frequency" |
Neonkraft
reviewed
May 5, 2025
| from confopt.oneshot.base import OneShotComponent | ||
|
|
||
|
|
||
| class CompositeSampler(OneShotComponent): |
There was a problem hiding this comment.
Why inherit from OneShotComponent? Why not inherit from BaseSampler?
Neonkraft
reviewed
May 5, 2025
| **kwargs, | ||
| ) | ||
|
|
||
| def _initialize_sampler_config(self) -> None: |
There was a problem hiding this comment.
function is defined but never consumed.
EDIT: I see it's called in the base class
Neonkraft
reviewed
May 5, 2025
|
|
||
| if sampler == SamplerType.COMPOSITE: | ||
| sub_samplers: list[BaseSampler] = [] | ||
| for _, sampler_config in config.items(): |
There was a problem hiding this comment.
If I'm not mistaken, config.items() might not return the values in a specific order. This might mean that multiple instantiations of the CompositeSampler with the same samplers might have the samplers in different order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds-
CompositeSampler- Sampler from a mixture of sub-sampler (in an order)CompositeProfile- Takes in a list of SamplerTypes and corresponding configs for sampling.