Refactor serial console migration #6598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor provider infrastructure to use the new recreate_serial_console parameter instead of manually calling cleanup_serial_console() and create_serial_console() before wait_for_serial_login(). Modified files: - provider/save/save_base.py: pre_save_setup() and post_save_check() - provider/migration/base_steps.py: PrepareVMTest and VerifyTest classes - provider/migration/migration_base.py: poweroff_vm_on_dest() and do_io_error_on_dest() - provider/interface/check_points.py: check_vm_network_accessed() Depends on: avocado-framework/avocado-vt#4248 Signed-off-by: hholoubk <[email protected]>
Refactor all migration tests to use the recreate_serial_console parameter instead of manually calling cleanup_serial_console() and create_serial_console() before wait_for_serial_login(). This simplifies serial console management when switching connection URIs during migration operations. The pattern is especially useful after migrating VMs to remote hosts where the serial console needs to be recreated to match the new connection context. Modified test categories: - Memory migration tests: migrate_mem.py - Network migration tests: migrate_network.py (3 occurrences) - Migration with panic device: migrate_with_panic_device.py - Migration with virtiofs: internally/externally launched virtiofs devices (2 files) - Migration with vTPM: shared_tpm, vtpm_dev, external_tpm (3 files) All tests now use a cleaner pattern: vm.connect_uri = dest_uri vm_session = vm.wait_for_serial_login(timeout=240, recreate_serial_console=True) Total: 8 files modified with 31 fewer lines of console management code. Depends on: avocado-framework/avocado-vt#4248 Depends on: autotest#6596 Signed-off-by: hholoubk <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional note - the cleanup_serial_console and create_serial_console already contains the check, that the console is not None