feat: define explicit associated types on Hashable #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
from
3e79cd6 to
99974a1
Compare
demosdemon
force-pushed
the
brandon.leblanc/hashable-kvp-trie
branch
from
0c736bb to
6d3d794
Compare
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
from
99974a1 to
dbb899d
Compare
demosdemon
force-pushed
the
brandon.leblanc/hashable-kvp-trie
branch
from
6d3d794 to
47e37cd
Compare
rkuris
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my next pull request, I have a need for these to be defined as explicit associated types. This was pulled out into a separate change for simplicity.