feat: add TriePathIter for iterating over the nodes along a path #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demosdemon
force-pushed
the
brandon.leblanc/trie-path-iter
branch
2 times, most recently
from
6d39ab2 to
d710821
Compare
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
from
3e79cd6 to
99974a1
Compare
demosdemon
force-pushed
the
brandon.leblanc/trie-path-iter
branch
from
d710821 to
2446fa7
Compare
demosdemon
changed the title
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
from
99974a1 to
dbb899d
Compare
demosdemon
force-pushed
the
brandon.leblanc/trie-path-iter
branch
from
2446fa7 to
787fe3c
Compare
rkuris
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Let's chat about this and how it differs from the existing MerkleNodeIter. The existing code is tested heavily as it forms the basis of MerkleKeyValueIter.
If this code is better/faster/more generic, lets describe which and the motivation for a new iterator more clearly in the PR description.
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
from
dbb899d to
366441a
Compare
demosdemon
force-pushed
the
brandon.leblanc/trie-path-iter
branch
from
787fe3c to
30e63e5
Compare
`TrieNode` is a generic trait that abstracts over the behavior of nodes in a fixed-arity radix trie. This trait allows for different structures to represent tries while enabling similar operations on them. `TrieNode` is merkle-aware, meaning it can represent nodes that are a mix of locally described children or children referenced by only their hash. This is accomplished through `TrieEdgeState` and is used later in proof verification. The `HashedTrieNode` trait is for post-hashed nodes and is distinctly different from the hash described on `TrieNode`. This trait is intended to represent the computed hash of the node itself; whereas, the hash accessed via `TrieNode` is the hash of a child node as seen from its parent. While they are usually the same, they can differ during intermediate states of a trie or during proof verification when some information is incomplete. `KeyValueTrieRoot` is an implementation of `TrieNode` that only represents a key-value store and is not merkleized. This is really a separate change and is a component of proof verification but is also needed here as it is used to test and verify the iterator.
This expands on the previously added key-value trie by adding a hashed variant and mechanism to convert from unhashed to hashed.
demosdemon
force-pushed
the
brandon.leblanc/trie-path-iter
branch
from
30e63e5 to
8b019d4
Compare
demosdemon
force-pushed
the
brandon.leblanc/hashable-assoc-types
branch
2 times, most recently
from
7cf3d26 to
9087e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to walk along a path to yield all of the edges. In proof verification, this is used to verify the paths of the proof are valid.