Reuse network in e2e test #819
Conversation
ylg-avalabs
requested review from
bernard-avalabs,
geoff-vball,
iansuvak,
mdelle1 and
michaelkaplan13
| log.Info("Waiting for 10s to ensure no new block confirmations on destination chain") | ||
| Consistently(newHeadsB, 10*time.Second, 500*time.Millisecond).ShouldNot(Receive()) | ||
| // log.Info("Waiting for 10s to ensure no new block confirmations on destination chain") | ||
| // Consistently(newHeadsB, 10*time.Second, 500*time.Millisecond).ShouldNot(Receive()) |
There was a problem hiding this comment.
Why do we need this check? With reusing network, it failed to pass this check.
There was a problem hiding this comment.
Yes, it still failed. Can we remove this check?
|
I tried running this but couldn't get it to work. Where is the default location for I would have expected to be able to set
|
When we run the test in normal case ( 
|
|
I do like Geoff's suggestion of creating a network if not already present and then re-using it if it is |
| log.Info("Waiting for 10s to ensure no new block confirmations on destination chain") | ||
| Consistently(newHeadsB, 10*time.Second, 500*time.Millisecond).ShouldNot(Receive()) | ||
| // log.Info("Waiting for 10s to ensure no new block confirmations on destination chain") | ||
| // Consistently(newHeadsB, 10*time.Second, 500*time.Millisecond).ShouldNot(Receive()) |
There was a problem hiding this comment.
in the e2e tests, why do we create a subnet and then convert it to an L-1
There was a problem hiding this comment.
To test the L1 case. In general networks first get created as subnets and the concept of subnet still remains, i.e. they are still referred to by their subnetID even if they are L1s
5 participants
Why this should be merged
How this works
network-dirflag to passing in the network directory storing network infonetwork-dirflag is set, it loads the network from the directory and set the saved teleporter registry addresses and validator addressesHow this was tested
How is this documented