sync: coreth PR #1279: style: forbidigo t.Fatal #1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
changed the title
Signed-off-by: Jonathan Oppenheimer <[email protected]>
ARR4N
reviewed
Nov 17, 2025
ARR4N
reviewed
Nov 17, 2025
ARR4N
reviewed
Nov 17, 2025
ARR4N
reviewed
Nov 17, 2025
alarso16
previously requested changes
Nov 17, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
The point of the linter is to use the helper functions. require.Fail should be avoided whenever possible
Contributor
|
What's with the goleak failures? It's weird because the |
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/sync-pr-1279-forbidgo
branch
from
52bb4cd to
25db6a9
Compare
Member
Author
Done -- see #1865 |
Member
Author
|
This blocked by this PR |
Signed-off-by: Jonathan Oppenheimer <[email protected]>
ceyonur
previously requested changes
Nov 21, 2025
Co-authored-by: Ceyhun Onur <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
ceyonur
approved these changes
Nov 24, 2025
ceyonur
reviewed
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs ava-labs/coreth#1279.
Note: The first commit 96fc992 is a perfect cherry pick of the coreth changes. These should not be reviewed stringently -- if you have changes, make them to coreth first~
The second commit 1a0ecea contains subnet-evm specific changes and should be reviewed as normal
--