sync: coreth PR #1394: ci: Missing test import lint #1869
+58
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
changed the title
JonathanOppenheimer
changed the title
ceyonur
previously requested changes
Nov 21, 2025
…ixes Signed-off-by: Jonathan Oppenheimer <[email protected]>
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/sync-pr-1394-ci-lint-fixes
branch
from
2c325eb to
8752280
Compare
alarso16
reviewed
Nov 24, 2025
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
| ctx := t.Context() | ||
| snowCtx := utilstest.NewTestSnowContext(t) | ||
| snowCtx := snowtest.Context(t, SubnetEVMTestChainID) | ||
| validatorState := utilstest.NewTestValidatorState() |
Member
Author
There was a problem hiding this comment.
we need to separately define this to set GetValidatorSetF on line 96.
alarso16
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs ava-labs/coreth#1394, but not really...
These changes are more just general divergences between subnet-evm and coreth that are corrected here. If you don't think this is appropriate, please just close this PR.