sync: coreth PR #1392: chore: Add lint link check job #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]>
JonathanOppenheimer
changed the title
JonathanOppenheimer
requested review from
a team and
maru-ava
as code owners
maru-ava
approved these changes
Nov 24, 2025
alarso16
previously requested changes
Nov 24, 2025
| @@ -1,3 +1,4 @@ | |||
| <!-- markdownlint-disable MD041 --> | |||
Member
Author
There was a problem hiding this comment.
I learned that this actually doesn't not show up even if present in a PR when posted / previewed. Still remove?
Contributor
There was a problem hiding this comment.
It definitely shows up in a PR
cmd/simulator/README.md
Outdated
| 2. Automatically opts in to validate every Subnet | ||
|
|
||
| Once you have AvalancheGo running locally, it will be running an HTTP Server on the default port `9650`. This means that the RPC Endpoint for the C-Chain will be http://127.0.0.1:9650/ext/bc/C/rpc and ws://127.0.0.1:9650/ext/bc/C/ws for WebSocket connections. | ||
| Once you have AvalancheGo running locally, it will be running an HTTP Server on the default port `9650`. This means that the RPC Endpoint for the C-Chain will be `http://127.0.0.1:9650/ext/bc/C/rpc` and `ws://127.0.0.1:9650/ext/bc/C/ws` for WebSocket connections. |
Contributor
There was a problem hiding this comment.
Is this comment right? I'm not sure it should be talking about the C-Chain at all
Member
Author
There was a problem hiding this comment.
Yeah I assume this was copied incorrectly copied years ago. Does the current state look better?
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
reviewed
Nov 25, 2025
Contributor
There was a problem hiding this comment.
I think this is also a geth readme
| # Subnet-EVM Configuration | ||
|
|
||
| > **Note**: These are the configuration options available in the Subnet-EVM codebase. To set these values, you need to create a configuration file at `~/.avalanchego/configs/chains/<blockchainID>/config.json`. | ||
| > **Note**: These are the configuration options available in the subnet-evm codebase. To set these values, you need to create a configuration file at `{chain-config-dir}/C/config.json`. This file does not exist by default. |
Contributor
There was a problem hiding this comment.
I think this is also a cherry-pick error. On this line and the one below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs ava-labs/coreth#1392