feat: convert native minter npm test to go test #1872

JonathanOppenheimer · 2025-11-21T20:52:29Z

Why this should be merged

Replaces native minter e2e hardhat tests with golang bindings and a simulated backend test.

Part of #1228

How this works

Generates relevant golang bindings from sol files for the testing. Mirrors the hardhat test to a golang test using simulated backend.

How this was tested

CI

Need to be documented?

No

Need to update RELEASES.md?

No

…test

JonathanOppenheimer · 2025-11-21T21:21:43Z

precompile/contracts/nativeminter/nativemintertest/compile.go

@@ -0,0 +1,13 @@
+// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.


This whole package seems like a mess. Is the correct structure? It's not like the deployerallowlist package, because the minter is not tested seperately like allowlist is.

JonathanOppenheimer · 2025-11-21T21:22:51Z

precompile/contracts/nativeminter/nativemintertest/config_test.go

@@ -1,7 +1,7 @@
 // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.


I moved these in to match what you did for the deployerallowlist. I think all of these folders need to be cleaned up / reorganized, but I would appreciate your guidance @ceyonur

xxxtest packages are mostly meant for test-related but not actual UT files (test utility files mostly). There is a cyclic dependency so we cannot really put these simulatedtest/binding files under the related precompile packages (like nativeminter/). I was going to suggest reverting other changes and add another simulatedtest packages but I was not aware that we had another cyclic dependency introduced with extstate cleanup.

I think in that case we can move all these precompile tests to their relevant test packages. (like nativemintertest or testnativeminter etc). If you feel like it will be cleaner we can introduce simulatetest packages, but it seems that we need to move config_test and contract_test into xxxtest packages anyway.

trying to put everything in the top level package also results in cyclic dependencies.

Would you like to put a PR up into this PR to restructure the files? I'm not sure if I follow exactly what you are suggesting. It really is a mess...

Yeah gosh this is really messy. What are your thoughts on another bindings folder? or some way to split things up better?

.github/workflows/ci.yml

precompile/contracts/testutils/simulated_helpers.go

JonathanOppenheimer · 2025-11-21T22:15:59Z

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

+		test func(t *testing.T, backend *sim.Backend, nativeMinterIntf *INativeMinter)
+	}
+
+	testCases := []testCase{


all of these tests are 1:1 copies of the tests in https://github.com/ava-labs/subnet-evm/blob/c65752b631b07206d506111cd52e5d686a9f02b0/contracts/contracts/test/ERC20NativeMinterTest.sol

We should be getting rid of these ERC20 related testing (and openzeppelin lib)

Is the coverage still good now? post removal?

yea I think so.

.github/workflows/ci.yml

ceyonur · 2025-11-24T09:51:51Z

precompile/contracts/nativeminter/nativemintertest/solidity/ERC20NativeMinter.sol

@@ -1,27 +1,31 @@
 //SPDX-License-Identifier: MIT
 pragma solidity ^0.8.24;


can we get rid of this file? I don't think this is a viable testing for this and we should not be importing any extra contracts.

Instead we can use a much simpler approach that only issues mintNativeCoin (similar to allowlist tests.)

Yup I've deleted this file entirely -- let me know what you think of NativeMinterTest.

it looks good!

ceyonur · 2025-11-24T10:47:38Z

precompile/contracts/nativeminter/nativemintertest/config_test.go

@@ -1,7 +1,7 @@
 // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.


xxxtest packages are mostly meant for test-related but not actual UT files (test utility files mostly). There is a cyclic dependency so we cannot really put these simulatedtest/binding files under the related precompile packages (like nativeminter/). I was going to suggest reverting other changes and add another simulatedtest packages but I was not aware that we had another cyclic dependency introduced with extstate cleanup.

I think in that case we can move all these precompile tests to their relevant test packages. (like nativemintertest or testnativeminter etc). If you feel like it will be cleaner we can introduce simulatetest packages, but it seems that we need to move config_test and contract_test into xxxtest packages anyway.

ceyonur · 2025-11-24T10:52:48Z

precompile/allowlist/allowlisttest/AllowList.sol

@@ -1,7 +1,7 @@
 //SPDX-License-Identifier: MIT
 pragma solidity ^0.8.24;


why did we move these files to Solidity? I think it makes sense to keep them together with their bindings.

I was just trying to simplify the structure -- I think it needs a more thorough approach though.

ceyonur · 2025-11-24T10:58:36Z

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

+		test func(t *testing.T, backend *sim.Backend, nativeMinterIntf *INativeMinter)
+	}
+
+	testCases := []testCase{


We should be getting rid of these ERC20 related testing (and openzeppelin lib)

ceyonur · 2025-11-24T11:40:23Z

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

+func setAsEnabled(t *testing.T, b *sim.Backend, nativeMinter *INativeMinter, auth *bind.TransactOpts, address common.Address) {
+	t.Helper()
+	tx, err := nativeMinter.SetEnabled(auth, address)
+	require.NoError(t, err)
+	testutils.WaitReceiptSuccessful(t, b, tx)
+}


I think this can be move to allowlisttest package as a test helper.

I can't move a test package there because there's another importcycle when I do it that way

feemanager (test) -> allowlisttest -> ethclient/simulated -> core -> feemanager

So I put the allowlist test helpers in testutils.

ceyonur · 2025-11-24T11:40:37Z

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

+	return addr, contract
+}
+
+func verifyRole(t *testing.T, nativeMinter *INativeMinter, address common.Address, expectedRole allowlist.Role) {


This can be move to allowlisttest package as a test helper.

See above comment.

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

…test

ceyonur

overall it's looking good. We just need to the helper file and decide the test structure in #1878

ceyonur · 2025-11-26T10:15:07Z

precompile/contracts/testutils/allowlist_helpers.go

+	"github.com/stretchr/testify/require"
+
+	"github.com/ava-labs/subnet-evm/accounts/abi/bind"
+	"github.com/ava-labs/subnet-evm/precompile/allowlist"


Isn't it best to move this file to the allowlisttest to reduce the imported packages?

ceyonur · 2025-11-26T10:20:28Z

precompile/contracts/nativeminter/nativemintertest/simulated_test.go

+		test func(t *testing.T, backend *sim.Backend, nativeMinterIntf *INativeMinter)
+	}
+
+	testCases := []testCase{


yea I think so.

ceyonur · 2025-11-26T10:21:36Z

precompile/contracts/testutils/allowlist_helpers.go

the file looking good 👍 , it's just would fit better to allowlisttest.

ceyonur · 2025-11-26T11:40:42Z

precompile/contracts/nativeminter/nativemintertest/solidity/ERC20NativeMinter.sol

@@ -1,27 +1,31 @@
 //SPDX-License-Identifier: MIT
 pragma solidity ^0.8.24;


it looks good!

ceyonur · 2025-11-26T11:40:52Z

precompile/contracts/nativeminter/nativemintertest/config_test.go

@@ -1,7 +1,7 @@
 // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.


JonathanOppenheimer requested a review from ceyonur November 21, 2025 20:52

JonathanOppenheimer self-assigned this Nov 21, 2025

JonathanOppenheimer added ci testing This primarly focuses on testing labels Nov 21, 2025

JonathanOppenheimer added 2 commits November 21, 2025 15:53

feat: convert mint precompile testing to go

030967e

Add abi files back

b7eec85

JonathanOppenheimer force-pushed the JonathanOppenheimer/convert-native-minter-test branch from a93e2b6 to b7eec85 Compare November 21, 2025 20:59

JonathanOppenheimer added 2 commits November 21, 2025 16:03

restore files

5a0ccbb

restore name

ef32f2f

JonathanOppenheimer force-pushed the JonathanOppenheimer/convert-native-minter-test branch from 4131d69 to ef32f2f Compare November 21, 2025 21:11

JonathanOppenheimer added 2 commits November 21, 2025 16:20

remove from compile

3359ca9

Merge branch 'master' into JonathanOppenheimer/convert-native-minter-…

5c6d601

…test

JonathanOppenheimer commented Nov 21, 2025

View reviewed changes

JonathanOppenheimer added 3 commits November 21, 2025 16:27

add submodules

6a0d4b8

remove old contract

f88e5b2

shell-check modificaiton

2db1281

JonathanOppenheimer marked this pull request as ready for review November 21, 2025 21:47

JonathanOppenheimer requested review from a team and maru-ava as code owners November 21, 2025 21:47

JonathanOppenheimer changed the title ~~feat: convert native minter test to go framework~~ feat: convert native minter npm test to go test Nov 21, 2025

JonathanOppenheimer commented Nov 21, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

JonathanOppenheimer commented Nov 21, 2025

View reviewed changes

precompile/contracts/testutils/simulated_helpers.go Show resolved Hide resolved

JonathanOppenheimer commented Nov 21, 2025

View reviewed changes

ceyonur requested changes Nov 24, 2025

View reviewed changes

JonathanOppenheimer added 5 commits November 24, 2025 12:42

test: remove openzeppelin and erc20 tests

561029d

test: remove openzeppelin

679e30e

Merge branch 'master' into JonathanOppenheimer/convert-native-minter-…

87f3bd5

…test

test: remove old compile from CI

4225a1a

test: define allowlist helpers

d42393a

JonathanOppenheimer added 2 commits November 24, 2025 17:10

test: get rid of solidity folder

e0d7787

chore: regenerate bindings

56bf03c

JonathanOppenheimer requested a review from ceyonur November 24, 2025 22:14

JonathanOppenheimer added 2 commits November 24, 2025 17:16

chore: lint

a924883

chore: license header

e33233f

ceyonur reviewed Nov 26, 2025

View reviewed changes

		@@ -0,0 +1,13 @@
		// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.

		@@ -1,7 +1,7 @@
		// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.

		@@ -1,27 +1,31 @@
		//SPDX-License-Identifier: MIT
		pragma solidity ^0.8.24;

feat: convert native minter npm test to go test #1872

Are you sure you want to change the base?

feat: convert native minter npm test to go test #1872

Conversation

JonathanOppenheimer commented Nov 21, 2025

Why this should be merged

How this works

How this was tested

Need to be documented?

Need to update RELEASES.md?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ceyonur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development