PVT-550-PVT-551--from-PVT-221-2 match format - #12
Draft
mmcardle wants to merge 1 commit into
Draft
Conversation
aw-sohonet
requested changes
Oct 15, 2025
| printf("Testcard capture set to %dx%d\n", s->desc.width, s->desc.height); | ||
| log_msg(LOG_LEVEL_INFO, MOD_NAME "capture set to %dx%d @%.2gp, codec %s, bpc %d, pattern: %s, audio %s\n", | ||
| s->desc.width, s->desc.height, s->desc.fps, get_codec_name(s->desc.color_spec), | ||
| get_bits_per_component(s->desc.color_spec), "bars", s->grab_audio ? "on" : "off"); |
Owner
There was a problem hiding this comment.
Can we move this log line to be just before the gettimeofday. Although everything should be fully set at this point, it does seem to set the s->grab_audio again (already set above).
| #include "utils/macros.h" | ||
| #include "utils/thread.h" | ||
| #include "video.h" | ||
| #include "video_codec.h" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
testcard2to output to match the format oftestcardand to be parsed by our log collector.