PVT-135 - Re-added packet pacing to threaded video network implementation - #7
Open
aw-sohonet wants to merge 10 commits into
Open
PVT-135 - Re-added packet pacing to threaded video network implementation#7aw-sohonet wants to merge 10 commits into
aw-sohonet wants to merge 10 commits into
Conversation
…e rate as a default (rather than a default that would not work on 60fps, and unlikely to work in 30fps). Also updated it so that the bitrate values will be respected (regarding UNLIMITED - All other values default to using the existing rules). Updated the timing report to include the target (if one has been set).
…rings by converting the static strings to be C++ strings.
heindsight
reviewed
Jun 27, 2023
…hed int type to be 64-bit so we do not overflow when storing nanosecond timings.
heindsight
reviewed
Jun 27, 2023
| std::chrono::duration targetDuration = std::chrono::nanoseconds(packetDurationTarget) * (loopIndex + 1); | ||
| std::chrono::high_resolution_clock::time_point target = start + targetDuration; | ||
| // Loop until we're on target | ||
| while(std::chrono::high_resolution_clock::now() < target); |
Collaborator
There was a problem hiding this comment.
It may be worth logging the amount of time spent blocked here.
Fixed typo and updated constructor to use raw type. Removed warning by adding forward declaration of the `calculateFromTarget` function.
heindsight
approved these changes
Jun 27, 2023
gowikel
approved these changes
Jul 31, 2023
…levant information in log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added packet pacing to the threaded network implementation: