Skip to content

feat(gen2-migration): add deployment status validation for lock command #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: gen2-migration
Choose a base branch
from
Open

feat(gen2-migration): add deployment status validation for lock command #14326

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7357f60
chore: add deployment status validation for lock command
Nov 7, 2025
887db55
chore: add UPDATE_ROLLBACK_COMPLETE to valid deployment statuses
Nov 7, 2025
fe290b9
chore: update error message to exclude UPDATE_ROLLBACK_COMPLETE from …
Nov 8, 2025
ba03e99
chore: regenerate yarn.lock to fix lockfile drift
Nov 10, 2025
7e6b269
Revert "chore: regenerate yarn.lock to fix lockfile drift"
Nov 10, 2025
95eb78e
chore: sync yarn.lock with base branch
Nov 10, 2025
5482906
Merge remote-tracking branch 'origin/gen2-migration' into sai/validat…
Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/amplify-cli/src/commands/gen2-migration/_validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,17 @@ export class AmplifyGen2MigrationValidations {
}

const stackStatus = response.Stacks[0].StackStatus;
const validStatuses = ['UPDATE_COMPLETE', 'CREATE_COMPLETE'];
// Note: UPDATE_ROLLBACK_COMPLETE isn't an expected state - only being added in the edge case of resuming migration from a failed state
const validStatuses = ['UPDATE_COMPLETE', 'CREATE_COMPLETE', 'UPDATE_ROLLBACK_COMPLETE'];

if (!validStatuses.includes(stackStatus)) {
throw new AmplifyError('StackStateError', {
message: `Root stack status is ${stackStatus}, expected ${validStatuses.join(' or ')}`,
message: `Root stack status is ${stackStatus}, expected UPDATE_COMPLETE or CREATE_COMPLETE`,
resolution: 'Complete the deployment before proceeding.',
});
}

printer.success(`Deployment status validated: ${stackStatus}`);
}

public async validateDeploymentVersion(): Promise<void> {
Expand Down
Loading