fix(release): decouple amazon-cognito-identity-js latest dist-tag from postpublish hook#14846
Open
bobbor wants to merge 1 commit into
Open
fix(release): decouple amazon-cognito-identity-js latest dist-tag from postpublish hook#14846bobbor wants to merge 1 commit into
bobbor wants to merge 1 commit into
Conversation
…ublish The per-package postpublish hook ran 'npm dist-tag add ... latest' mid lerna parallel-publish, where lerna swallowed its output and a single failure aborted the entire LTS release. Move it to an explicit step that runs after the fleet publish so failures are visible and retryable without re-publishing. Also pull --rebase before pushing post-release changes to avoid non-fast-forward push failures.
|
bobbor
changed the title
soberm
reviewed
Jun 23, 2026
| github_user: ${{ vars.GH_USER}} | ||
| github_email: ${{ vars.GH_EMAIL}} | ||
|
|
||
| - name: Promote amazon-cognito-identity-js to the "latest" dist-tag |
Contributor
There was a problem hiding this comment.
Should we move this step after push or mark with continue-on-error ? If dist-tag fails the commit/tags never get pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v5 LTS release was failing on the
amazon-cognito-identity-jspostpublishhook, which rannpm dist-tag add … latestinside lerna's parallel publish. lerna swallowed the hook's stderr and a single failure aborted the entire fleet release — leaving the v5 line partially published (the umbrellaaws-amplifyand several@aws-amplify/*packages never reached npm even though their versions were bumped, committed, and tagged).This moves the
latestdist-tag promotion out of the package lifecycle and into an explicit, sequential release step.Changes
packages/amazon-cognito-identity-js/package.json— remove thepostpublishhook (npm dist-tag add $npm_package_name@$npm_package_version latest)..github/workflows/callable-npm-publish-lts-release.ymlgit pull --rebasebefore the post-releasegit pushto fix the separate non-fast-forward push failure seen on 06-12.amazon-cognito-identity-jsis the only package with apostpublishand the only unscoped package whoselatestmust track the v5 line while the rest of the fleet ridesstable-5; everything else is unaffected.Why
Testing
yarn && yarn bootstrap && yarn buildgreen on the branch (Node 22).lerna publish from-package(10 packages republished tostable-5;aws-amplify@5.3.35now resolves all pinned deps).Notes