fix: wrap plain Error from fetch as NetworkError in React Native#14850
Open
PHILLIPS71 wants to merge 2 commits into
Open
fix: wrap plain Error from fetch as NetworkError in React Native#14850PHILLIPS71 wants to merge 2 commits into
PHILLIPS71 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: c35057a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
fetchTransferHandleronly caughtTypeErrorwhenfetch()rejected, converting it to a namedNetworkError. This is correct for browsers, where the Fetch spec mandatesTypeErrorfor network failures.React Native's native network layer throws plain Error objects instead of
TypeError. These slipped through theinstanceof TypeErrorcheck, were rethrown as-is, and eventually reachedassertServiceErrorin the auth package. BecauseassertServiceErrortreats any error withname === 'Error'as an unknown failure, it wrapped them inAuthError({ name: 'Unknown' }), discarding all network error context. Callers had no way to distinguish a network failure from a genuine unexpected error.The fix catches all non-abort errors from
fetch()and wraps them asNetworkError. Aborts are explicitly re-thrown unchanged. This is safe becausefetch()only rejects for two reasons: abort signals and network failures. HTTP error responses (4xx, 5xx) resolve normally and never reach the catch block.Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.