Skip to content

chore: fix test workflows #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 18, 2025
Merged

chore: fix test workflows #4057

merged 10 commits into from
Sep 18, 2025

Conversation

@thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Sep 16, 2025 •
edited
Loading

Issue #

None

Description

This PR

  • disables flaky unit tests in AWSS3StoragePlugin and AWSCloudWatchLoggingPlugin
  • enables disabled schemes in API Integration tests except AWSAPIPluginLazyLoadTests

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash
Copy link
Member Author

thisisabhash commented Sep 18, 2025

Integration test run successful: https://github.com/aws-amplify/amplify-swift/actions/runs/17819283277

@harsh62 harsh62 merged commit acdd2dc into main Sep 18, 2025
115 checks passed
@harsh62 harsh62 deleted the chore/fix-test-workflows branch September 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsh62 harsh62 harsh62 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thisisabhash @harsh62