Skip to content

Fix/extra parens #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Fix/extra parens #124

merged 3 commits into from
Jul 14, 2025

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Jul 13, 2025

Prior to this change there were cases where extra parenthesis () would show up and you could see double parenthesis ()().

I don't think this affects Erlang, but not 100%.

The only test that is fail is this one:

test/aws_codegen_test.exs:781: (test)

djgoku added 2 commits July 13, 2025 01:27
This function takes in a string and only adds `()` when there are no
previous parens.
@onno-vos-dev
Copy link
Member

Code LGTM 👍 Just wanna verify locally how the generated code changes to be on the safe side 🙂

@onno-vos-dev
Copy link
Member

Nice, this fixes the bug for aws-erlang as well while you were at it so that's confirmed 🎉 🥇

@onno-vos-dev
Copy link
Member

I'm testing the build failure for aws-erlang in the PR mentioned above before pushing that change to your branch 👍 Give me a bit of time to sort that one out.

@onno-vos-dev onno-vos-dev merged commit 03c8dfe into aws-beam:master Jul 14, 2025
3 checks passed
@onno-vos-dev
Copy link
Member

onno-vos-dev commented Jul 14, 2025

Thank you! I'll have a look as to why OTP 27 was failing s3_SUITE in aws-erlang since it isn't failing in my branch on aws-erlang (see branch) 😕 Will try to figure this out before tagging new releases in aws-elixir and aws-erlang.

@onno-vos-dev
Copy link
Member

Thank you! I'll have a look as to why OTP 27 was failing s3_SUITE in aws-erlang since it isn't failing in my branch on aws-erlang (see branch) 😕 Will try to figure this out before tagging new releases in aws-elixir and aws-erlang.

I can't replicate the errors on OTP 27 locally so for now we'll test the aws-codegen for Erlang on OTP 26 👍 I'll pick this up some other day again.

@onno-vos-dev
Copy link
Member

@djgoku Thank you for the PR! Released new versions of both aws-elixir (v1.0.7) and aws-erlang (1.1.2) now 🎉

Thanks again 🙇

@djgoku djgoku deleted the fix/extra-parens branch July 14, 2025 14:05
@djgoku
Copy link
Contributor Author

djgoku commented Jul 14, 2025

@onno-vos-dev I didn't even think to run each repos tests! Glad this fixed other issues too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants