Skip to content

fix: unable to serialize array with unique items #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Jan 17, 2023

Issue #, if available: #97

Description of changes:

Whenever defining an array with unique items in the resource, we will ensure those are serialized correctly instead of throwing an error.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eduardomourar eduardomourar marked this pull request as ready for review January 17, 2023 11:38
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 98.56% // Head: 98.56% // No change to project coverage 👍

Coverage data is based on head (79090d3) compared to base (4581156).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          14       14           
  Lines        1250     1250           
  Branches      209      209           
=======================================
  Hits         1232     1232           
  Misses         17       17           
  Partials        1        1           
Flag Coverage Δ
unittests 98.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/recast.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmaeng
Copy link
Contributor

mmaeng commented Jan 19, 2023

LGTM!

@Luke-Davies
Copy link

Hi all, I hope this doesn't come across as rude but is there a reason why this hasn't been merged and released?

@mmaeng
Copy link
Contributor

mmaeng commented Feb 13, 2023

Apologies! Let me do it now.

@mmaeng mmaeng merged commit 3b44251 into aws-cloudformation:master Feb 13, 2023
@Luke-Davies
Copy link

Great thanks @mmaeng. Are you waiting to release a new version or could we get a new patch version release now?

@mmaeng
Copy link
Contributor

mmaeng commented Feb 14, 2023

There is release 1.0.4 that was cut that doesn't include this release #95 so this will be included in the following release.

@eduardomourar eduardomourar deleted the fix/array-unique-items branch February 14, 2023 21:49
@Luke-Davies
Copy link

Great, when will we get the following release? Apologies if there is somewhere I can look to figure this out myself.

@mmaeng
Copy link
Contributor

mmaeng commented Feb 15, 2023

We are working on automating the release process across all the cli and plugin repos. Once that is in place it will be on a more regular cadence but at the moment it is a very manual process with no set schedule. Let me check with the team if we could get this PR included in 1.0.4 and get that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants