fix: unable to serialize array with unique items#98
fix: unable to serialize array with unique items#98mmaeng merged 4 commits intoaws-cloudformation:masterfrom
Conversation
Codecov ReportBase: 98.56% // Head: 98.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 14 14
Lines 1250 1250
Branches 209 209
=======================================
Hits 1232 1232
Misses 17 17
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM! |
|
Hi all, I hope this doesn't come across as rude but is there a reason why this hasn't been merged and released? |
|
Apologies! Let me do it now. |
|
Great thanks @mmaeng. Are you waiting to release a new version or could we get a new patch version release now? |
|
There is release 1.0.4 that was cut that doesn't include this release #95 so this will be included in the following release. |
|
Great, when will we get the following release? Apologies if there is somewhere I can look to figure this out myself. |
|
We are working on automating the release process across all the cli and plugin repos. Once that is in place it will be on a more regular cadence but at the moment it is a very manual process with no set schedule. Let me check with the team if we could get this PR included in 1.0.4 and get that out. |
Issue #, if available: #97
Description of changes:
Whenever defining an array with unique items in the resource, we will ensure those are serialized correctly instead of throwing an error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.