Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for noecho override #38

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

leohoare
Copy link
Contributor

@leohoare leohoare commented May 21, 2020

Issue #19

Description of changes:
Have loved using this helper for custom resources, although a big of a shame it's missing the NoEcho.
this would provide basic functionality to override NoEcho such as:
helper.NoEcho = True
I'm happy to add in some tests and update docs/provide an example. I'm just gaining initial opinions on the approach.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #38 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   94.43%   94.44%           
=======================================
  Files           8        8           
  Lines         647      648    +1     
  Branches       44       44           
=======================================
+ Hits          611      612    +1     
  Misses         23       23           
  Partials       13       13           
Impacted Files Coverage Δ
crhelper/resource_helper.py 90.00% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2e9e9...cc77636. Read the comment docs.

@leohoare
Copy link
Contributor Author

@jaymccon are you still moderating this project? would be nice to have this functionality.

@ddaubi
Copy link

ddaubi commented Nov 21, 2020

This is a must for secure deployment.

@tjbrockmeyer
Copy link

@jaymccon This is a good change. Can this get pulled in? It's been since May 2020

@zdot
Copy link

zdot commented Jan 27, 2021

Would be great to get this merged.

@jaymccon jaymccon merged commit 4058ba7 into aws-cloudformation:master Jan 28, 2021
@zdot
Copy link

zdot commented Jan 28, 2021

@jaymccon Thank you! Appreciate your work on this project.

@ddaubi
Copy link

ddaubi commented Feb 4, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants