Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove apigateway for shameList #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Mar 28, 2025

This pull request aims to remove API Gateway from the shameList, as the original reason for its inclusion is no longer valid. In the AWS SDK v1, there was an inconsistency in the naming convention between input and output shapes for API Gateway operations. Specifically, input shapes followed a pattern like CreateDomainNameInput, while output shapes were simply named DomainName. This inconsistency was one of the reasons API Gateway was placed on the shameList.

However, with the release of AWS SDK v2, this naming inconsistency has been resolved. The new SDK now uses a standardized naming pattern for both input and output shapes across API Gateway operations. As a result, the special handling that was required is no longer necessary.

For reference, we can compare the old naming convention in SDK v1 (link) with the new, consistent naming in SDK v2 (link).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 28, 2025 21:59
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-prow ack-prow bot added the approved label Mar 31, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
Copy link

ack-prow bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

a-hilaly commented Apr 4, 2025

thanks for the description @rushmash91 !

@a-hilaly
Copy link
Member

a-hilaly commented Apr 4, 2025

/retest

4 similar comments
@rushmash91
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Apr 4, 2025

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Apr 4, 2025

/retest

@michaelhtm
Copy link
Member

/retest

Copy link

ack-prow bot commented Apr 4, 2025

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution a2d0564 link false /test verify-attribution
s3-olm-test a2d0564 link false /test s3-olm-test
ec2-controller-test a2d0564 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants