-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove apigateway for shameList #577
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for the description @rushmash91 ! |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This pull request aims to remove API Gateway from the shameList, as the original reason for its inclusion is no longer valid. In the AWS SDK v1, there was an inconsistency in the naming convention between input and output shapes for API Gateway operations. Specifically, input shapes followed a pattern like
CreateDomainNameInput
, while output shapes were simply namedDomainName
. This inconsistency was one of the reasons API Gateway was placed on the shameList.However, with the release of AWS SDK v2, this naming inconsistency has been resolved. The new SDK now uses a standardized naming pattern for both input and output shapes across API Gateway operations. As a result, the special handling that was required is no longer necessary.
For reference, we can compare the old naming convention in SDK v1 (link) with the new, consistent naming in SDK v2 (link).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.