add update version force annotation #153
Conversation
rushmash91
force-pushed
the
update-version
branch
from
9ffe698 to
5b39255
Compare
pkg/resource/cluster/hook.go
Outdated
| const ( | ||
| // AnnotationPrefix is the prefix for all annotations specifically for | ||
| // the EKS service. | ||
| AnnotationPrefix = "eks.services.k8s.aws/" | ||
| // AnnotationForceUpgrade is an annotation whose value indicates whether | ||
| // the cluster version upgrade should be forced even if there are cluster insight findings. | ||
| AnnotationForceUpgrade = AnnotationPrefix + "force-upgrade" | ||
|
|
||
| DefaultForceUpgrade = false | ||
| ) |
There was a problem hiding this comment.
annotations looks pretty good..i'm wondering if we should keep it consistent across the controllers tho..
rds does it this way: https://github.com/aws-controllers-k8s/rds-controller/blob/edae298800eb4089dffffde7ece63c6a827cacb5/apis/v1alpha1/annotation.go#L18-L45
There was a problem hiding this comment.
Yeah, i was looking at this one, the same behavior for ecr: https://github.com/aws-controllers-k8s/ecr-controller/blob/main/pkg/resource/repository/hook.go#L18-L27
There was a problem hiding this comment.
i agree v1alpha1/apis is abetter place, i did put those in ECR and I regret that choice, we ideally to move them
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
ack-prow
bot
added
lgtm
rushmash91
force-pushed
the
update-version
branch
from
d9e4eac to
89c36ee
Compare
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue: aws-controllers-k8s/community#2409
Description of changes:
Updates Go SDK version to
v1.36.3and removes new fields from CRDsAdds support for force upgrade annotation in EKS clusters, allowing users to force version upgrades even when there are cluster insight findings that would normally block the upgrade.
eks.services.k8s.aws/force-upgradeannotationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.