Skip to content

Add CidrCollection support to route53 controller#47

Closed
gvdhart wants to merge 2 commits intoaws-controllers-k8s:mainfrom
ubbleai:feat/add-cidr-collections
Closed

Add CidrCollection support to route53 controller#47
gvdhart wants to merge 2 commits intoaws-controllers-k8s:mainfrom
ubbleai:feat/add-cidr-collections

Conversation

@gvdhart
Copy link
Copy Markdown
Contributor

@gvdhart gvdhart commented Jul 23, 2024

Issue #, if available: NA

Description of changes:
Adding CidrCollection compatibility to the route53 controller

  • Create and Delete CidrCollections
  • Put and Delete CidrLocations and CidrBlocks in a CidrCollection
    All using a single k8s resource for each AWS cidr Collection.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gvdhart
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot requested a review from a-hilaly July 23, 2024 12:41
@ack-prow ack-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2024
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Jul 23, 2024

Hi @gvdhart. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Jul 23, 2024

/ok-to-test

@ack-prow ack-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2024
a-hilaly
a-hilaly reviewed Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gvdhart !! i did a quick review to the API and the comparison functions, please let me know what you think.

Comment thread apis/v1alpha1/cidr_collection.go

// Information about changes to a CIDR collection.
// +kubebuilder:validation:Required
Locations []*CIDRCollectionChange `json:"locations"`
Copy link
Copy Markdown
Member

@a-hilaly a-hilaly Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to be a [][]CIDRBlocks ? Also wondering if we really need the Action field.

Copy link
Copy Markdown
Contributor Author

@gvdhart gvdhart Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we technically do not need the Action field in the resource definition, however I used the generator to create this field, let me check if I can simplify this part as indeed it would be nicer to have a cidrBlock representation here.

Copy link
Copy Markdown
Contributor Author

@gvdhart gvdhart Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After investigation I do not think that a CIdrBlock type is the best here, there is just a string in it that contains all cidrblocks, not a list of strings. Furthermore I would have to complicate things in the genrator file to get that working. I would prefer to leave it like this.
Sure the Action field is not required as I set it in the code, but i could not manage to have it removed with the generator.

Comment thread pkg/resource/cidr_collection/hooks.go
@gvdhart gvdhart force-pushed the feat/add-cidr-collections branch 2 times, most recently from 1cfc8f2 to 92a2bff Compare August 23, 2024 13:03
@gvdhart
Copy link
Copy Markdown
Contributor Author

gvdhart commented Aug 23, 2024

/retest

@gvdhart gvdhart force-pushed the feat/add-cidr-collections branch from 92a2bff to 2d9f8d3 Compare September 10, 2024 12:18
@gvdhart
Copy link
Copy Markdown
Contributor Author

gvdhart commented Sep 10, 2024

@a-hilaly I think it is good to go!
However I have one test that fails 'route53-verify-attribution' but I don't know what this one does and it never failed before.

@gvdhart
Copy link
Copy Markdown
Contributor Author

gvdhart commented Sep 17, 2024

/retest

@gvdhart gvdhart requested a review from a-hilaly September 24, 2024 13:40
@ack-bot
Copy link
Copy Markdown
Collaborator

ack-bot commented Mar 23, 2025

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 23, 2025
@a-hilaly a-hilaly removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2025
@ack-bot
Copy link
Copy Markdown
Collaborator

ack-bot commented Sep 21, 2025

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2025
@ack-bot
Copy link
Copy Markdown
Collaborator

ack-bot commented Dec 29, 2025

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-prow ack-prow Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 29, 2025
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Feb 20, 2026

@gvdhart: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
route53-verify-attribution 2d9f8d3 link false /test route53-verify-attribution
route53-recommended-policy-test 2d9f8d3 link true /test route53-recommended-policy-test
route53-metadata-file-test 2d9f8d3 link true /test route53-metadata-file-test
route53-kind-e2e 2d9f8d3 link true /test route53-kind-e2e
route53-release-test 2d9f8d3 link true /test route53-release-test
route53-unit-test 2d9f8d3 link true /test route53-unit-test
route53-crd-compat-check 2d9f8d3 link true /test route53-crd-compat-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-bot
Copy link
Copy Markdown
Collaborator

ack-bot commented Apr 22, 2026

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-prow ack-prow Bot closed this Apr 22, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented Apr 22, 2026

@ack-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@a-hilaly a-hilaly

@rushmash91 rushmash91

@michaelhtm michaelhtm

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gvdhart @a-hilaly @ack-bot @rushmash91 @michaelhtm