fix: support fqdn record names #72
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
force-pushed
the
fix/supportfqdnrecordnames
branch
2 times, most recently
from
4f426f4 to
bac9874
Compare
Currently we append the hostedZoneName to the RecordSet at create. If the recordSet name is fqdn, we want to avoid doing so. With this change, the hostedZoneName will not be appended to an FQDN
michaelhtm
force-pushed
the
fix/supportfqdnrecordnames
branch
from
bac9874 to
109770d
Compare
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #2232
Description of changes:
Currently we append the hostedZoneName to the RecordSet at create.
If the recordSet name is FQDN, we want to avoid doing so.
With this change, the hostedZoneName will not be appended to an FQDN
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.