fix: Correct IAM policy BatchGetSecretValue in external secrets #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with the external-secrets documentation here: https://external-secrets.io/v0.20.1/provider/aws-secrets-manager/#iam-policy and AWS docs here: https://docs.aws.amazon.com/secretsmanager/latest/userguide/auth-and-access_iam-policies.html#auth-and-access_examples_batch secretsmanager:BatchGetSecretValue should be against resource "*" rather than the individual secret. closes aws-ia#475
bdellegrazie
changed the title
bdellegrazie
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
Author
|
Not stale! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes external-secrets use of
BatchGetSecretValueby correcting the IAM policy in accordance with the external-secrets documentation and AWS docs.IAM permission
secretsmanager:BatchGetSecretValueshould be against resource*rather than the individual secret.Motivation
More
pre-commit run -awith this PRFor Moderators