feat(parser): add support for tumbling windows in Kinesis and DynamoDB events #3931
Conversation
boring-cyborg
bot
added
parser
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
@leandrodamascena |
dreamorosi
changed the title
github-actions
bot
added
feature
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
added
do-not-merge
dreamorosi
removed
do-not-merge
|
|
@kiitosu thank you for the PR, I made some small fixes in the Kinesis schema which was implemented as a type and fixed the indentation of one of the comments. I also adapted the unit tests to be in line with the others. As soon as another maintainer approves the PR we're good to merge it. @am29d I had to make a commit to fix the things above, can you pls review and approve when you can? The schemas were tested by Leandro in the same PR but in the Python repo. |
| * "kinesis": { | ||
| * "kinesisSchemaVersion": "1.0", | ||
| * "partitionKey": "1", | ||
| * "sequenceNumber": "49590338271490256608559692540925702759324208523137515618", | ||
| * "data": "VGhpcyBpcyBvbmx5IGEgdGVzdC4=", | ||
| * "approximateArrivalTimestamp": 1545084711.166 | ||
| * }, | ||
| * "eventSource": "aws:kinesis", | ||
| * "eventVersion": "1.0", | ||
| * "eventID": "shardId-000000000006:49590338271490256608559692540925702759324208523137515618", | ||
| * "eventName": "aws:kinesis:record", | ||
| * "invokeIdentityArn": "arn:aws:iam::123456789012:role/lambda-role", | ||
| * "awsRegion": "us-east-2", | ||
| * "eventSourceARN": "arn:aws:kinesis:us-east-2:123456789012:stream/lambda-stream" |
There was a problem hiding this comment.
Why do we remove these fields from the example? Or was it unintentional?
Summary
Enable TumblingWindow support for KinesisDataStreamRecord and DynamoDB.
Changes
Added properties to support tumbling windows in KinesisStreamEvent and DynamoDBStream Event:
Issue number: #3915
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.