feat(metrics): use async local storage for metrics (#4663) #4694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Last week we had to revert several PRs due to an issue with the InvokeStore module. This module has now been patched.
This PR re-introduces support for using an async context in the Metrics utility. This allows users to emit metrics that are isolated specifically to the current lambda invocation, isolated from any other executions.
Changes
MetricsStoreMetadataStoreDimensionStoreMetricsclass only accesses the data in these stores through this interface and never touches the stored objects directly.InvokeStorecontext: if they are then the metrics are stored in the current async context, otherwise we fallback to a plain instance wide object as per the current implementation.Metricsclass, e.g.,setMetricwill check if the metric already exists and handle converting values into an array if the metric is already there. Likewise with setting timestamps.Metricsclass as a whole.Issue number: closes #4662
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.