Skip to content

Conversation

@dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Nov 15, 2025

Summary

Changes

Please provide a summary of what's being changed

This PR adds e2e tests for the HTTP Router part of the Event Handler utility.

The end to end test deploys a single CloudFormation stack with one lambda function that includes dozens of routes split between a few routers that are then merged into a single app.

The routes are intended to cover most of the use cases I could think of (with LLM help for the spec) and the tests are done by making direct requests using the fetch module.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4502


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Nov 15, 2025
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Nov 15, 2025
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Nov 15, 2025
@dreamorosi
Copy link
Contributor Author

dreamorosi commented Nov 15, 2025

Before I can remove the .skip statements & TODOs from the tests we need to merge #4750 and address #4751.

@sonarqubecloud
Copy link

@dreamorosi dreamorosi marked this pull request as ready for review November 19, 2025 16:18
@dreamorosi
Copy link
Contributor Author

Thanks for the engagement in the discussion - I have removed the tests and noted them down in their respective issues.

The current test suite is passing: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/19507043601

@dreamorosi dreamorosi requested review from sdangol and svozza November 19, 2025 16:30
@dreamorosi dreamorosi merged commit bd69383 into main Nov 19, 2025
67 checks passed
@dreamorosi dreamorosi deleted the test/evt_handler branch November 19, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Add e2e Tests for Event Handler REST API

3 participants