Update dataset_validator.py #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standard call to get cpu count. os.cpu_count()
ivan-tse
reviewed
Mar 26, 2025
| @@ -235,7 +235,7 @@ def process_s3_path(path, is_invocation_logs): | |||
|
|
|||
| def validate_prompts_in_parallel(prompts, file_path, is_invocation_logs): | |||
| """Validates the given prompts in parallel""" | |||
| max_workers = os.process_cpu_count() | |||
| max_workers = os.cpu_count() | |||
There was a problem hiding this comment.
ProcessPoolExecutor uses os.process_cpu_count() by default - https://docs.python.org/3/library/concurrent.futures.html#:~:text=Changed%20in%20version%203.13%3A%20max_workers%20uses%20os.process_cpu_count()%20by%20default%2C%20instead%20of%20os.cpu_count(). What is the reason we want to change this to os.cpu_count()?
There was a problem hiding this comment.
it threw the error:
AttributeError: module 'os' has no attribute 'process_cpu_count'
Set up:
python3 -m venv env
source env/bin/activate
pip install -U pip
pip install -r requirements.txtpython3 dataset_validator.py -p /Users/user/Documents/tech/distillation/data/distillation_data.jsonlOutput
2025-03-27 11:01:15,537 - INFO - Validating file: /Users/user/Documents/tech/distillation/data/distillation_data.jsonl
AttributeError: module 'os' has no attribute 'process_cpu_count'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
*Description of changes:*standard call to get cpu count. os.cpu_count()
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.