remove part that determines how many bytes are needed since CRC32 alw… #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove part that determines how many bytes are needed since CRC32 always has 4-byte hash; that calculated wrong crc32 for some object parts.
Issue #, if available:
When performing a mulitpart upload the the get-object-attributes cli command provides the following output:
The checksums for each object part calculated by checksum verification tool:
The last two checksums are wrongly calculated.
Description of changes:
The issue in the original code was that m.bit_length() could vary, leading to inconsistent byte lengths. CRC32 should always be represented as 4 bytes. The change fixes the false positive.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.