Skip to content

Conversation

@pmadc
Copy link

@pmadc pmadc commented Sep 28, 2021

Description of changes:

Add instruction for AWS Codecommit integration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@andskli andskli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, I do think that this could be simplified a bit, let me explain; right now there's quite some duplicated content being added to README.md, perhaps the CodeCommit specific things could be moved into a separate markdown file and linked from section 2 in the existing README.md instead?

I would also encourage you to use git remotes in your instructions instead of copying the content of the repository.

@adambro
Copy link
Contributor

adambro commented Apr 13, 2022

It would be useful to have CodeCommit example, as using this text I was able to spot that I miss YOUR_SSH_KEY_ID in the URL and getting ssh: unable to authenticate errors. However I agree that this contribution requires redaction and polishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants